[PATCH] D43008: [ELF] Process linker scripts deeper when declaring symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 01:34:45 PST 2018


grimar added a comment.

LGTM with a nit.
(please wait for other reviewers approval)



================
Comment at: test/ELF/linkerscript/version-script.s:16
+# RUN:          }; \
+# RUN:       }" > %t.script
+# RUN: ld.lld -T %t.script -shared --no-undefined-version %t.o -o %t.so
----------------
Sorry for not being clear, I was mean it can not be single line because of 80 limit,
but we generally are trying to keep scripts short in testcases, it can be something,
just like:

```
echo "SECTIONS { .text : { bar = foo; *(.text) }} \
      VERSION { V { global: foo; bar; local: *; }; }" > %t.script
```


https://reviews.llvm.org/D43008





More information about the llvm-commits mailing list