[PATCH] D42872: Fix handling of zero-size segments in llvm-objcopy

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 01:21:13 PST 2018


jhenderson added a comment.

In https://reviews.llvm.org/D42872#1001000, @jakehehrlich wrote:

> This seems like the right choice to me given that information. I didn't realize the list of program header types was so small. This is clearly the right way to do it.


I agree with this. It's also easy enough to extend the list if and when new program header types are added in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D42872





More information about the llvm-commits mailing list