[PATCH] D42987: [libc++abi] fix compilation in C++17 mode

Eric Fiselier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 01:05:47 PST 2018


EricWF added a comment.

@rsmith. Sorry, you're right. I didn't notice that we already used `_LIBCPP_BUILDING_LIBRARY` in libc++abi.  I wasn't sure if `_BUILDING_LIBRARY` changed the linkage or of any symbols, or changed their explicit instantiation.
And, indeed, on Windows there's a problem with DLL import/export macros. I'll fix and cleanup the usage of `_BUILDING_LIBRARY` in the next couple days.


Repository:
  rL LLVM

https://reviews.llvm.org/D42987





More information about the llvm-commits mailing list