[llvm] r324550 - AMDGPU: Don't crash when trying to fold implicit operands

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 17:12:46 PST 2018


Author: arsenm
Date: Wed Feb  7 17:12:46 2018
New Revision: 324550

URL: http://llvm.org/viewvc/llvm-project?rev=324550&view=rev
Log:
AMDGPU: Don't crash when trying to fold implicit operands

Added:
    llvm/trunk/test/CodeGen/AMDGPU/fold-implicit-operand.mir
Modified:
    llvm/trunk/lib/Target/AMDGPU/SIFoldOperands.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/SIFoldOperands.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SIFoldOperands.cpp?rev=324550&r1=324549&r2=324550&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIFoldOperands.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/SIFoldOperands.cpp Wed Feb  7 17:12:46 2018
@@ -345,6 +345,7 @@ void SIFoldOperands::foldOperand(
     // Don't fold into target independent nodes.  Target independent opcodes
     // don't have defined register classes.
     if (UseDesc.isVariadic() ||
+        UseOp.isImplicit() ||
         UseDesc.OpInfo[UseOpIdx].RegClass == -1)
       return;
   }

Added: llvm/trunk/test/CodeGen/AMDGPU/fold-implicit-operand.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/fold-implicit-operand.mir?rev=324550&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/fold-implicit-operand.mir (added)
+++ llvm/trunk/test/CodeGen/AMDGPU/fold-implicit-operand.mir Wed Feb  7 17:12:46 2018
@@ -0,0 +1,14 @@
+# RUN: llc -march=amdgcn -run-pass si-fold-operands -verify-machineinstrs -o - %s | FileCheck %s
+---
+# Make sure there is no crash when trying to fold an immediate into an
+# implicit use
+
+# CHECK: %0:vgpr_32 = V_MOV_B32_e32 0, implicit $exec
+# CHECK-NEXT: S_ENDPGM implicit %0
+name: fold_imm_implicit_operand
+body:             |
+  bb.0:
+    %0:vgpr_32 = V_MOV_B32_e32 0, implicit $exec
+    S_ENDPGM implicit %0
+
+...




More information about the llvm-commits mailing list