[PATCH] D43046: [Windows] Set the console output page to UTF-8

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 16:01:07 PST 2018


amccarth added inline comments.


================
Comment at: llvm/lib/Support/Windows/Process.inc:273
+  // Set the console to output UTF-8.
+  ::SetConsoleOutputCP(CP_UTF8);
   return std::error_code();
----------------
I agree that we should _not_ change the console's code page, but if we do, we should make an effort to change it back.  That would still be less than ideal if the program crashes, and you might have two resize events.


https://reviews.llvm.org/D43046





More information about the llvm-commits mailing list