[PATCH] D43043: [DebugInfo] Unify ChecksumKind and Checksum value in DIFile
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 7 16:00:58 PST 2018
aprantl added inline comments.
================
Comment at: include/llvm/IR/DebugInfoMetadata.h:502
public:
- // These values must be explictly set, as they end up in the final object
+ // These values must be explicitly set, as they end up in the final object
// file.
----------------
These should be `///` Doxygen comments.
================
Comment at: include/llvm/IR/DebugInfoMetadata.h:519
+ ChecksumKind Kind;
+ /// The string value of the checksum.
+ T Value;
----------------
If this is a string, why does this need to be a template?
================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1357
IsDistinct = Record[0];
+ Optional<DIFile::ChecksumInfo<MDString *>> Checksum;
+ // The BitcodeWriter writes null bytes into Record[3:4] when the Checksum
----------------
When changing Bitcode, please always add a .bc upgrade test of the old format to test/Bitcode
Repository:
rL LLVM
https://reviews.llvm.org/D43043
More information about the llvm-commits
mailing list