[PATCH] D42495: [WebAssembly] Add symbol table to LLVM, 2/2

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:151
+// Information about a single entry to be written to the symbol table
+struct WasmSymbolEntry {
+  StringRef Name;
----------------
Isn't this now the same as WasmSymbolInfo?  (i.e. can we remove this?


================
Comment at: lib/MC/WasmObjectWriter.cpp:1017
+      SymbolInfos.emplace_back(
+          WasmSymbolEntry{WS.getName(), static_cast<unsigned>(WS.getType()),
+                          Flags, WasmIndices[&WS], None});
----------------
The return value of getType() here needs to be WASM_SYMBOL_TYPE_*.. but its currently a  MCSymboLWasm::SymbolType.   Rather than casting here, can we just remove MCSymboLWasm::SymbolType completely?


Repository:
  rL LLVM

https://reviews.llvm.org/D42495