[PATCH] D40032: [compiler-rt] Replace forkpty with posix_spawn
Kuba (Brecka) Mracek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 7 14:28:12 PST 2018
kubamracek added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:229
+
+ slave_fd = open(slave_pty_name, O_RDWR);
+ if (slave_fd == -1) goto cleanup;
----------------
dvyukov wrote:
> Don't we want to use internal_open/internal_close here? open/close are intercepted.
Updated patch. Although on Darwin, there's no difference, plain calls to open/close call the original functions.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D40032
More information about the llvm-commits
mailing list