[PATCH] D42935: [X86] Use min/max for vector ult/ugt compares if avoids a sign flip.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 12:40:40 PST 2018


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:18008
+                                              VET == MVT::i32)) ||
+                    (Subtarget.hasSSE2() && (VET == MVT::i8)));
+  if (UseMinMax) {
----------------
RKSimon wrote:
> Use IsOperationLegal instead? I think that'd add VLX v2i64/v4i64 support?
hasAVX512() && VET == MVT::i64 should cover VLX as well since AVX512 is a subset of VLX.

But I agree is OperationLegal would be cleaner.


https://reviews.llvm.org/D42935





More information about the llvm-commits mailing list