[PATCH] D42872: Fix handling of zero-size segments in llvm-objcopy

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

In https://reviews.llvm.org/D42872#1000943, @ruiu wrote:

> Ignoring sections with virtual memory size 0 and file size 0 is perhaps safe, but I wonder if we need to rely on the heuristics. There are only a few segment types that are used for "markers". Namely, you can ignore just PT_GNU_STACK and PT_OPENBSD_WXNEEDED. It seems to me that it's easier to understand than checking the segment size.


This seems like the right choice to me given that information. I didn't realize the list of program header types was so small. This is clearly the right way to do it.


Repository:
  rL LLVM

https://reviews.llvm.org/D42872