[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

In https://reviews.llvm.org/D43002#1000863, @zturner wrote:

> In https://reviews.llvm.org/D43002#1000838, @aprantl wrote:
>
> > There is still the question on how this is supposed to behave in an LTO build? Do you want the name of the shared LTO.o file for all CUs, or do you want to preserve the names of the bitcode-.o files? If the former is the case, then it makes more sense to make this a property of the Module, otherwise it needs to be on the DICompileUnit.
>
>
> I mentioned in another response but it might have been overlooked.  It needs to be the bitcode-.o files.


Thanks.

>> Should this not be gated on the debuginfo kind being codeview?
> 
> Couldn't a non-CodeView processor just ignore this field if they aren't interested in it?  I can't think of a good reason to gate it at this high of a level.

It needlessly increases the size of the intermediate products in the LTO case on non-windows platforms and every time we encode any paths in Clang build products we are inviting problems with non-reproducible builds.
Related question: does `remapDIPath` do the right thing for the *output* file?


https://reviews.llvm.org/D43002