[PATCH] D43005: [ARM] Error out on .arm assembler directives on windows

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D43005#1000822, @compnerd wrote:

> I think we should first clarify that currently the only Windows on ARM support is Windows ARM NT (Windows ARM CE still does have both modes of execution).  The important thing to note here is that although the CPU supports both modes of execution, the Windows ARM NT kernel does not guarantee the current mode will be preserved (that is, if you trap into the kernel in ARM mode, you are probably going to come out in Thumb mode and fault).


Yup - this is mentioned (briefly) in the corresponding place in ARMSubtarget.cpp, where NoARM is set for windows.

> I agree that we should try to fix this generally rather than hardcode this to Windows ARM.

Any concrete suggestions on how to go about it? The flag ARM::FeatureNoARM is generally assigned based on the cpu in ARM.td.


Repository:
  rL LLVM

https://reviews.llvm.org/D43005