[PATCH] D43029: Fix PR36268

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 10:33:13 PST 2018


hans added inline comments.


================
Comment at: llvm/include/llvm/IR/GlobalValue.h:118
+        (!hasDefaultVisibility() && !hasExternalWeakLinkage()))
+      setDSOLocal(true);
+  }
----------------
Can this flip back and forth? That is, if setDSOLocal(true) was set before, do we need to handle the else-branch here and do setDSOLocal(false)?


https://reviews.llvm.org/D43029





More information about the llvm-commits mailing list