[PATCH] D42475: [ELF] Add warnings for various symbols that cannot be ordered

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 133212.
jhenderson marked 4 inline comments as done.
jhenderson added a comment.

Address review comments:

- Move struct back into buildSectionOrder()
- Move priority and presence initialisation back to buildSectionOrder()
- Simplify initial check in getSymbolOrderingFile()
- Use "B" macro for new options

I haven't gone as far as @rafael suggested on the mailing list and moved everything back into the Writer (except for the reading in), since that seemed to be against what @ruiu and @grimar prefer. I'm happy with it either way.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42475

Files:
  ELF/Config.h
  ELF/Driver.cpp
  ELF/Options.td
  ELF/Writer.cpp
  test/ELF/Inputs/symbol-ordering-file-warnings1.s
  test/ELF/Inputs/symbol-ordering-file-warnings2.s
  test/ELF/symbol-ordering-file-warnings.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42475.133212.patch
Type: text/x-patch
Size: 13326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180207/a48976e7/attachment-0001.bin>