[PATCH] D42965: [CodeGen] Add a -trap-unreachable option for debugging
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 7 03:01:14 PST 2018
dmgreen updated this revision to Diff 133188.
dmgreen edited the summary of this revision.
dmgreen added a reviewer: kparzysz.
dmgreen removed a subscriber: kparzysz.
dmgreen added a comment.
Thanks! Now removes the old option.
https://reviews.llvm.org/D42965
Files:
lib/CodeGen/LLVMTargetMachine.cpp
lib/Target/Hexagon/HexagonTargetMachine.cpp
test/CodeGen/ARM/trap-unreachable.ll
test/CodeGen/Hexagon/trap-unreachable.ll
Index: test/CodeGen/Hexagon/trap-unreachable.ll
===================================================================
--- test/CodeGen/Hexagon/trap-unreachable.ll
+++ test/CodeGen/Hexagon/trap-unreachable.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=hexagon -hexagon-trap-unreachable < %s | FileCheck %s
+; RUN: llc -march=hexagon -trap-unreachable < %s | FileCheck %s
; CHECK: call abort
define void @fred() #0 {
Index: test/CodeGen/ARM/trap-unreachable.ll
===================================================================
--- /dev/null
+++ test/CodeGen/ARM/trap-unreachable.ll
@@ -0,0 +1,8 @@
+; RUN: llc -mtriple=thumbv7 -trap-unreachable < %s | FileCheck %s
+; CHECK: .inst.n 0xdefe
+
+define void @test() #0 {
+ unreachable
+}
+
+attributes #0 = { nounwind }
Index: lib/Target/Hexagon/HexagonTargetMachine.cpp
===================================================================
--- lib/Target/Hexagon/HexagonTargetMachine.cpp
+++ lib/Target/Hexagon/HexagonTargetMachine.cpp
@@ -97,10 +97,6 @@
static cl::opt<bool> EnableVExtractOpt("hexagon-opt-vextract", cl::Hidden,
cl::ZeroOrMore, cl::init(true), cl::desc("Enable vextract optimization"));
-static cl::opt<bool> EnableTrapUnreachable("hexagon-trap-unreachable",
- cl::Hidden, cl::ZeroOrMore, cl::init(false),
- cl::desc("Enable generating trap for unreachable"));
-
/// HexagonTargetMachineModule - Note that this is used on hosts that
/// cannot link in a library unless there are references into the
/// library. In particular, it seems that it is not possible to get
@@ -219,8 +215,6 @@
TT, CPU, FS, Options, getEffectiveRelocModel(RM),
getEffectiveCodeModel(CM), (HexagonNoOpt ? CodeGenOpt::None : OL)),
TLOF(make_unique<HexagonTargetObjectFile>()) {
- if (EnableTrapUnreachable)
- this->Options.TrapUnreachable = true;
initializeHexagonExpandCondsetsPass(*PassRegistry::getPassRegistry());
initAsmInfo();
}
Index: lib/CodeGen/LLVMTargetMachine.cpp
===================================================================
--- lib/CodeGen/LLVMTargetMachine.cpp
+++ lib/CodeGen/LLVMTargetMachine.cpp
@@ -34,6 +34,10 @@
#include "llvm/Target/TargetOptions.h"
using namespace llvm;
+static cl::opt<bool> EnableTrapUnreachable("trap-unreachable",
+ cl::Hidden, cl::ZeroOrMore, cl::init(false),
+ cl::desc("Enable generating trap for unreachable"));
+
void LLVMTargetMachine::initAsmInfo() {
MRI = TheTarget.createMCRegInfo(getTargetTriple().str());
MII = TheTarget.createMCInstrInfo();
@@ -79,6 +83,9 @@
this->RM = RM;
this->CMModel = CM;
this->OptLevel = OL;
+
+ if (EnableTrapUnreachable)
+ this->Options.TrapUnreachable = true;
}
TargetTransformInfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42965.133188.patch
Type: text/x-patch
Size: 2685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180207/e93c70fa/attachment.bin>
More information about the llvm-commits
mailing list