[PATCH] D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 01:24:43 PST 2018


fhahn added a comment.

Thanks for the patch, I think this would be a nice UI improvement. I agree with Sam, please use CPUNames and AArch64CPUNames. Also there are unit tests for the target parser in `unittests/Support/TargetParserTest.cpp`. Could you add some for the new functions?


Repository:
  rL LLVM

https://reviews.llvm.org/D42979





More information about the llvm-commits mailing list