[PATCH] D43004: [LNT] Use order_id for the Baselines menu and not id
Siddhesh Poyarekar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 6 23:39:32 PST 2018
siddhesh created this revision.
siddhesh added a reviewer: cmatthews.
Herald added a subscriber: llvm-commits.
The Baselines menu item selects the run to make the baseline but the ID in the menu was the primary key of the *_Baseline table. Use the order_id field instead, which is the actual run ID we want to set.
Repository:
rL LLVM
https://reviews.llvm.org/D43004
Files:
lnt/server/ui/templates/layout.html
Index: lnt/server/ui/templates/layout.html
===================================================================
--- lnt/server/ui/templates/layout.html
+++ lnt/server/ui/templates/layout.html
@@ -196,8 +196,8 @@
<ul class="dropdown-menu">
<li class="nav-header">Select baseline:</li>
{% for b in baselines %}
- {% set is_bold = b.id == baseline_id %}
- <li><a href="{{ v4_url_for('.v4_set_baseline', id=b.id) }}">
+ {% set is_bold = b.order_id == baseline_id %}
+ <li><a href="{{ v4_url_for('.v4_set_baseline', id=b.order_id) }}">
{% if is_bold %}
<b>{{ b.name }}</b>
{% else %}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43004.133156.patch
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180207/1090a654/attachment.bin>
More information about the llvm-commits
mailing list