[PATCH] D42872: Fix handling of zero-size segments in llvm-objcopy

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

I added James Henderson as I seem to recall we had this issue some time ago and apparently I added the problem back again somewhere along the way. I seem to recall James had an opinion on what counted as a dummy segment. Knowing past me I probably conservatively said a dummy segment is a segment with MemSize zero. I think the less conservative answer of if FileSize is zero is better now though. Alternatively we could try and make a comprehensive list of every dummy PT_* type

@jhenderson, @ruiu  what do you think? what should indicate that the offset of a segment should be left alone?


Repository:
  rL LLVM

https://reviews.llvm.org/D42872