[PATCH] D42998: [x86/retpoline] Make the external thunk names exactly match the names that happened to end up in GCC.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc marked an inline comment as done.
chandlerc added a comment.

In https://reviews.llvm.org/D42998#1000073, @jyknight wrote:

> Oops, just realized this won't necessarily always match: gcc would name the thunk `__x86_indirect_thunk_eax` for 32bit mode, and `__x86_indirect_thunk_rax` for 64bit mode.


How does this not match? We only use _eax, and only in 32-mode.

> Maybe it's only a theoretical issue because we only use r11 in 64bit mode though?

Not even a theoretical issue. LLVM has no code path that uses a register other than r11 in 64-bit mode as an explicit design decision, and we have asserts to that effect.


Repository:
  rL LLVM

https://reviews.llvm.org/D42998