[PATCH] D42495: [WebAssembly] Add symbol table to LLVM, 2/2

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 19:33:42 PST 2018


sbc100 added inline comments.


================
Comment at: include/llvm/BinaryFormat/Wasm.h:233
+  WASM_SYMTAB_DATA     = 0x1,
+  WASM_SYMTAB_GLOBAL   = 0x2,
+};
----------------
[Not really part of this change but...]  Should we add a separate type of BSS here?  Or can BSS symbols be expresses as DATA with no segment?

Should these be WASM_SYMTYPE_XXX or WASM_SYMBOL_XXX or maybe just WASM_SYM_XXX ?  


Repository:
  rL LLVM

https://reviews.llvm.org/D42495





More information about the llvm-commits mailing list