[PATCH] D42998: [x86/retpoline] Make the external thunk names exactly match the names that happened to end up in GCC.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 17:59:43 PST 2018


chandlerc created this revision.
chandlerc added reviewers: echristo, rnk, jyknight.
Herald added subscribers: hiraditya, mcrosier, sanjoy.

This is really unfortunate, as the names don't have much rhyme or reason
to them. Originally in the discussions it seemed fine to rely on aliases
to map different names to whatever external thunk code developers wished
to use but there are practical problems with that in the kernel it turns
out. And since we're discovering this practical problems late and since
GCC has already shipped a release with one set of names, we are forced,
yet again, to blindly match what is there.

Somewhat rushing this patch out for the Linux kernel folks to test and
so we can get it patched into our releases.


Repository:
  rL LLVM

https://reviews.llvm.org/D42998

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/X86/retpoline-external.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42998.133125.patch
Type: text/x-patch
Size: 7146 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180207/0c87c629/attachment.bin>


More information about the llvm-commits mailing list