[PATCH] D42988: Make sure that --no-check-sections doesn't print out warning messages.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 16:38:59 PST 2018


LGTM

Rui Ueyama via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> ruiu created this revision.
> ruiu added a reviewer: jhenderson.
> Herald added a subscriber: emaste.
>
> Make sure that --no-check-sections doesn't print out warning messages.
>
>
> https://reviews.llvm.org/D42988
>
> Files:
>   lld/test/ELF/linkerscript/overlapping-sections.s
>
>
> Index: lld/test/ELF/linkerscript/overlapping-sections.s
> ===================================================================
> --- lld/test/ELF/linkerscript/overlapping-sections.s
> +++ lld/test/ELF/linkerscript/overlapping-sections.s
> @@ -68,8 +68,8 @@
>  
>  # Check that we create the expected binary with --noinhibit-exec or --no-check-sections:
>  # RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --noinhibit-exec
> -# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --no-check-sections
> -# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --check-sections --no-check-sections
> +# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --no-check-sections -fatal-warnings
> +# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --check-sections --no-check-sections -fatal-warnings
>  
>  # Verify that the .sec2 was indeed placed in a PT_LOAD where the PhysAddr
>  # overlaps with where .sec1 is loaded:
>
>
> Index: lld/test/ELF/linkerscript/overlapping-sections.s
> ===================================================================
> --- lld/test/ELF/linkerscript/overlapping-sections.s
> +++ lld/test/ELF/linkerscript/overlapping-sections.s
> @@ -68,8 +68,8 @@
>  
>  # Check that we create the expected binary with --noinhibit-exec or --no-check-sections:
>  # RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --noinhibit-exec
> -# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --no-check-sections
> -# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --check-sections --no-check-sections
> +# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --no-check-sections -fatal-warnings
> +# RUN: ld.lld -o %t.so --script %t-lma.script %t.o -shared --check-sections --no-check-sections -fatal-warnings
>  
>  # Verify that the .sec2 was indeed placed in a PT_LOAD where the PhysAddr
>  # overlaps with where .sec1 is loaded:
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list