[PATCH] D42975: Store only argv[0] in Config
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 6 14:22:28 PST 2018
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/Driver.cpp:88-93
+ errorHandler().LogName = Config->ProgName;
+ errorHandler().ErrorLimitExceededMsg =
+ "too many errors emitted, stopping now (use "
+ "-error-limit=0 to see all errors)";
+ errorHandler().ErrorOS = &Error;
+ errorHandler().ColorDiagnostics = Error.has_colors();
----------------
Could you keep this at the beginning of the function? `make` shouldn't report an error, but it is easy to add more code before this code if we don't have this at the beginning.
https://reviews.llvm.org/D42975
More information about the llvm-commits
mailing list