[PATCH] D42759: [CGP] Split large structs to sink more GEPs

[Tobias Edler von Koch via Phabricator via llvm-commits]

tobiasvk added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:428
+                                    Type::getInt8Ty(F.getContext()), 0))
+      EnableSplitLargeStruct = false;
+  }
----------------
Drive-by comment: it's not a good idea to modify a cl::opt here as this will create (benign) races between multiple backend threads in ThinLTO.


Repository:
  rL LLVM

https://reviews.llvm.org/D42759