[PATCH] D42880: [dsymutil] Upstream update feature.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 10:42:41 PST 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D42880#999331, @davide wrote:

> Just a couple of nits.


I have to admit that I didn't measure its impact, but it's how it's currently implemented on our internal branch. The DwarfLinker isn't exactly super fast and obviously we don't want to risk it becoming slower for this (really unlikely) `update` path. If you're really opposed to this I can do some measurements. but in the end I don't think it hurts readability/maintainability which motivates me to err on the side of caution.


https://reviews.llvm.org/D42880





More information about the llvm-commits mailing list