[PATCH] D41860: [CallSiteSplitting] Support splitting of blocks with instrs before call.

Jun Bum Lim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 10:22:57 PST 2018


junbuml added inline comments.


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:85
+                                  "their cost is below DuplicationThreshold"),
+                         cl::init(50));
+
----------------
Considering that TCC_Basic is 1, don't you think 50 is too aggressive? For me, the conservative enough default should be TCC_Expensive. 


https://reviews.llvm.org/D41860





More information about the llvm-commits mailing list