[PATCH] D42737: [LegalizeDAG] Truncate condition operand of ISD::SELECT

[Elena Demikhovsky via Phabricator via llvm-commits]

delena added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:368
 
+  // Truncate the condition if needed
+  auto BoolVT = getSetCCResultType(CondVT);
----------------
Can the condition be wider than getSetCCResultType?


================
Comment at: test/CodeGen/AArch64/expand-select.ll:4
+; Check that we don't crash
+; RUN: llc -mtriple=aarch64-unknown-linux-gnu -O3 %s -o -
+
----------------
I think you should put here regular CHECKs, like in all other llc tests.


https://reviews.llvm.org/D42737