[PATCH] D42762: Rewrite the VS Integration Scripts

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 132907.
zturner added a comment.

Added a UI setting that allows the user to choose a custom path to clang.  It defaults to `$(LLVMInstallDir)bin\clang-cl.exe`.  I added this to the general page of the UI.  I then initialize the value of `$(CLToolExe)` with the value of this setting in the `.targets` file.  And since I'm mucking with that page anyway, removed some settings that don't apply to clang-cl, surrounding managed code and App Store stuff.

Also fixed a bug where `DebuggerFlavor` wasn't being initialized in the `.props` file, the effect of which was that you couldn't debug unless you explicitly went to the debugger page and chose `Local Windows Debugger`.


https://reviews.llvm.org/D42762

Files:
  clang/tools/driver/CMakeLists.txt
  llvm/CMakeLists.txt
  llvm/tools/msbuild/.gitignore
  llvm/tools/msbuild/CMakeLists.txt
  llvm/tools/msbuild/LLVM.Cpp.Common.props
  llvm/tools/msbuild/LLVM.Cpp.Common.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.LLVM-vs2010.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.LLVM-vs2012.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.LLVM-vs2012_xp.targets
  llvm/tools/msbuild/Microsoft.Cpp.Win32.llvm.props.in
  llvm/tools/msbuild/Platformx64/Toolset.props
  llvm/tools/msbuild/Platformx64/Toolset.targets
  llvm/tools/msbuild/Platformx86/Toolset.props
  llvm/tools/msbuild/Platformx86/Toolset.targets
  llvm/tools/msbuild/clang-cl-general.xml
  llvm/tools/msbuild/clang-cl.xml
  llvm/tools/msbuild/install.bat
  llvm/tools/msbuild/license.txt
  llvm/tools/msbuild/llvm.csproj
  llvm/tools/msbuild/llvm.sln
  llvm/tools/msbuild/source.extension.vsixmanifest
  llvm/tools/msbuild/toolset-vs2013.targets
  llvm/tools/msbuild/toolset-vs2013_xp.targets
  llvm/tools/msbuild/toolset-vs2014.targets
  llvm/tools/msbuild/toolset-vs2014_xp.targets
  llvm/tools/msbuild/uninstall.bat

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42762.132907.patch
Type: text/x-patch
Size: 99329 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180206/6fbac8f4/attachment-0001.bin>