[PATCH] D42934: LTO: Also include dso-local bit for calls in ThinLTO cache key.

[Peter Collingbourne via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL324291: LTO: Also include dso-local bit for calls in ThinLTO cache key. (authored by pcc, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D42934?vs=132893&id=132900#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D42934

Files:
  llvm/trunk/lib/LTO/LTO.cpp
  llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll


Index: llvm/trunk/lib/LTO/LTO.cpp
===================================================================
--- llvm/trunk/lib/LTO/LTO.cpp
+++ llvm/trunk/lib/LTO/LTO.cpp
@@ -192,8 +192,10 @@
         UsedTypeIds.insert(TT.VFunc.GUID);
       for (auto &TT : FS->type_checked_load_const_vcalls())
         UsedTypeIds.insert(TT.VFunc.GUID);
-      for (auto &ET : FS->calls())
+      for (auto &ET : FS->calls()) {
+        AddUnsigned(ET.first.isDSOLocal());
         AddUsedCfiGlobal(ET.first.getGUID());
+      }
     }
   };
 
Index: llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll
===================================================================
--- llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll
+++ llvm/trunk/test/LTO/Resolution/X86/cache-dso-local2.ll
@@ -0,0 +1,23 @@
+; Tests whether the cache is sensitive to the dso-local bit on called
+; functions.
+; RUN: rm -rf %t.cache
+; RUN: opt -module-hash -module-summary -o %t.bc %s
+; RUN: llvm-lto2 run -o %t.o %t.bc -cache-dir %t.cache \
+; RUN:   -r %t.bc,foo,px \
+; RUN:   -r %t.bc,bar,px
+; RUN: llvm-lto2 run -o %t.o %t.bc -cache-dir %t.cache \
+; RUN:   -r %t.bc,foo,plx \
+; RUN:   -r %t.bc,bar,px
+; RUN: ls %t.cache | count 2
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define weak void @foo() {
+  ret void
+}
+
+define weak void @bar() {
+  call void @foo()
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42934.132900.patch
Type: text/x-patch
Size: 1421 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180205/ad3ed11b/attachment.bin>