[PATCH] D42925: Call FlushFileBuffers on readwrite file mappings.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 15:21:18 PST 2018


rnk added a comment.

One concern I have is that this is a common pattern on Linux:

  int fd = open(...);
  void *mem = mmap(fd, ...);
  close(fd);
  // use mem

Are we reasonably confident that LLVM doesn't have this pattern anywhere in it? i.e. we never store the FD and then try to use it after closing it?


https://reviews.llvm.org/D42925





More information about the llvm-commits mailing list