[lld] r324221 - [ELF] Implement --[no-]apply-dynamic-relocs option.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 10:02:44 PST 2018


Peter Smith <peter.smith at linaro.org> writes:

>> Please change the default.
>>
>> It is OK to have a --handle-bug-in-other-tool option, but it should
>> never be the default so that we reduce the chance of future tools having
>> the same bug.
>>
>>
>>
>> Please change this to just
>>
>> if (Config->ApplyDynamicRelocs && UseSymVA)
>>
>> by making Config->ApplyDynamicRelocs always true if we are not using Elf_Rela.
>>
>>
>> Cheers,
>> Rafael
>
> I'm happy to make the changes, I've got to leave the office in a few
> minutes so if it's ok I'll do that tomorrow. Feel free to make the
> change yourself or revert if it is time critical.

I will take care of it, no worries.

Cheers,
Rafael


More information about the llvm-commits mailing list