[PATCH] D42880: [dsymutil] Upstream update feature.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Couple nitpicks inline :-)



================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:512
 
+static bool inFunctionScope(CompileUnit &U, unsigned Idx) {
+  if (Idx == 0)
----------------
Comment about what this function does?


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:517
+    return true;
+  return inFunctionScope(U, U.getInfo(Idx).ParentIdx);
+}
----------------
should this be a loop instead of recursion? We previously ran into stack limits with dsymutil...


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:723
 
+  void copyInvariantDebugSection(const object::ObjectFile &Obj, LinkOptions &);
+
----------------
doxygen comment?


================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:90
+static opt<bool> Update(
+    "update",
+    desc("Updates existing dSYM files to contain the latest accelerator\n"
----------------
Does this need to go into the manpage, too?


Repository:
  rL LLVM

https://reviews.llvm.org/D42880