[PATCH] D42849: [ARM] Armv8.2-A FP16 code generation (part 3/3)

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer updated this revision to Diff 132835.
SjoerdMeijer added a comment.

Thanks for the review! 
Nits addressed, so this is the diff I will commit tomorrow.

> It might be better to write these tests as loading/storing the fp16 values,
>  rather than doing all of this bit-casting, to simplify the tests. However, if
>  you're going to do native support for fp16 args/returns in the backend soon,
>  I'd be fine with committing these as-is for now knowing that they'll be
>  simplified even further by that.

Yes, that was exactly my plan: when we have proper fp16 args/return support, I
will update these tests to reflect that. For now I would like to keep the IR
and tests like they are at the moment, because that's the IR that we currently
generate from source code.


https://reviews.llvm.org/D42849

Files:
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/ARM/ARMISelLowering.h
  lib/Target/ARM/ARMInstrVFP.td
  test/CodeGen/ARM/fp16-instructions.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42849.132835.patch
Type: text/x-patch
Size: 38710 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180205/d690050b/attachment.bin>