[PATCH] D42856: [ThinLTO] Convert dead alias to declarations
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 5 07:17:58 PST 2018
tejohnson marked 2 inline comments as done.
tejohnson added inline comments.
================
Comment at: lib/LTO/LTOBackend.cpp:410
- // Process functions and global now.
- // FIXME: add support for aliases (needs support in convertToDeclaration).
- for (auto &GV : Mod)
- MaybeDrop(GV);
- for (auto &GV : Mod.globals())
- MaybeDrop(GV);
+ for (GlobalValue *GV : ReplacedGlobals) GV->eraseFromParent();
}
----------------
grimar wrote:
> Please format (it should be 2 lines after clang-formatting I think).
clang-format did this, but it turns out it had the wrong style set as my default. Fixed.
Repository:
rL LLVM
https://reviews.llvm.org/D42856
More information about the llvm-commits
mailing list