[PATCH] D42873: [llvm-objcopy] Adjust --strip-dwo behavior

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Test case?

Hmm... I vaguely remember thinking that llvm-objcopy did the work in place already, but on further inspection, it doesn't and I don't think it ever did. The current behaviour is to output the file to a file called "-" if there is no output filename specified. I think this is wrong and not what was intended, but I'd like Jake's feedback on that one. For reference, GNU objcopy does its operations in place if there is no output file, at least for the very limited set that I tried. Given this, I think that the change shouldn't be specific to --strip-dwo, but should always be the case, i.e. the if-statement simply becomes:

  if (!OutputFilename.getNumOccurrences())
      Output = InputFilename;


Repository:
  rL LLVM

https://reviews.llvm.org/D42873