[PATCH] D42733: [ELF] - Use InitTargetOptionsFromCodeGenFlags/ParseCommandLineOptions for parsing LTO options.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Driver.cpp:697-698
+             !S.startswith("-pass-through="))
+      // Ignore options that might be passed by GCC and collect
+      // LTO options for futher proccessing.
+      LTOOptions.push_back(S.data());
----------------
ruiu wrote:
> I don't think you need this comment. This comment doesn't seem to make much sense to me because you are not ignoring options but collecting options in this `else if` clause. I'd just remove this comment.
Removed. Though it is unobvious I think that "/", "-fresolution=" and "-pass-through=" are options passed
for gold plugin and why should be ignored here.

I wonder if we actually want to error()/warn()/verbose them so that people could adjust their invocations to remove
excessive command line options when using lld instead gold+plugin.


https://reviews.llvm.org/D42733