[PATCH] D42203: [AMDGPU] Scratch setup fix on AMDPAL gfx9+ merge shader

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 01:08:55 PST 2018


tpr added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:397
+          // ES+GS merge shader on gfx9+.
+          GitPtrLo = AMDGPU::SGPR8;
+          break;
----------------
arsenm wrote:
> Why aren't there corresponding changes in SIISelLowering? I would expect the argument lowering code would need to be aware of this
The frontend does actually set up args for s0-s7 as well as the user sgprs starting at s8. So arg lowering does not need to do anything different.


Repository:
  rL LLVM

https://reviews.llvm.org/D42203





More information about the llvm-commits mailing list