[PATCH] D42691: [SimplifyCFG] Relax restriction for folding unconditional branches

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 4 20:25:42 PST 2018


skatkov added inline comments.


================
Comment at: test/Transforms/SimplifyCFG/UncondBranchToHeader.ll:16
+  br label %header
+exit:
+  ret i32 %i
----------------
skatkov wrote:
> efriedma wrote:
> > Do we really need SimplifyCFG to rotate loops?  We have a dedicated LoopRotate pass for this sort of transform.
> > 
> > But I guess it's okay.
> Hi Eli, I did not follow what you mean here as rotate loop?
> 
> Header will be the same. In this particular case the loop will just consists from one basic block header after transformation...
Or you mean that before it was not bottom formed loop and now it is?


https://reviews.llvm.org/D42691





More information about the llvm-commits mailing list