[PATCH] D42797: [LLD][ELF] Implement --[no-]apply-dynamic-relocs option.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 2 12:54:12 PST 2018
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/SyntheticSections.cpp:1211
+ // We store the addends for dynamic relocations for both REL and RELA
+ // relocations for compatibility with GNU Linkers. There is some system
+ // software such as the Bionic dynamic linker that uses the addend prior
----------------
I'd prefer to add "even though it's redundant" because it'd be the first thing to wonder when someone read this comment.
https://reviews.llvm.org/D42797
More information about the llvm-commits
mailing list