[PATCH] D42859: Consolidate --foo and --no-foo options. NFC.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/ELF/Options.td:57
+defm as_needed: B<"as-needed",
+    "Always DT_NEEDED for shared libraries",
+    "Only set DT_NEEDED for shared libraries if used">;
----------------
This looks like it's the wrong way around?


================
Comment at: lld/ELF/Options.td:74
+defm demangle: B<"demangle",
+    "Do not demangle symbol names",
+    "Demangle symbol names">;
----------------
Same here.


================
Comment at: lld/ELF/Options.td:320
+    "Force load of all members in a static library",
+    "Restores the default behavior of loading archive members">;
 
----------------
This should use the imperative tone to be consistent with all other options ("Restore the default behavior" instead of "Restores the default behavior"). I know you're just copying it from elsewhere, but this seems like a good opportunity to fix it.


https://reviews.llvm.org/D42859