[PATCH] D37775: Add a verifier test to check the access on both sides of COPY are the same

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added a comment.

I can push the getSizeInbits change in a NFC change all by itself, and then the verifier change can land separately once X86 finishes it?



================
Comment at: lib/CodeGen/TargetRegisterInfo.cpp:429
+TargetRegisterInfo::getRegSizeInBits(unsigned Reg,
+                                     const MachineRegisterInfo &MRI) const {
+  const TargetRegisterClass *RC = nullptr;
----------------
qcolombet wrote:
> This function is not consistent with RegisterBankInfo::getSizeInBits in the priority it gives to the different size when several sources are available (RC, Type).
> 
> RBI goes Type if any then RC, this one does the opposite and I believe this is not what we want.
> 
> At the very least, RBI should use this implementation instead of duplicating the logic.
Good catch. Will fix this.


https://reviews.llvm.org/D37775