[PATCH] D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line
Jim Ingham via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 2 10:07:43 PST 2018
jingham added a comment.
Looks fine.
One other point, I'm assuming you started this whole process because you saw a test case failure and went to fix it? If that's true, do you know how stable that failure was (was it overly dependent on accidents of the compiler or was it pretty clear the function we stepped too far past was always going to have two entry points & so cause the problem? If there was something we could do to make sure the test case doesn't fail to catch the error, that would help ensure this didn't regress.
Of course if you just did this speculatively not because of a test failure, we probably should have a test.
https://reviews.llvm.org/D42582
More information about the llvm-commits
mailing list