[PATCH] D42832: [AArch64][GlobalISel] Use getRegClassForTypeOnBank() in selectCopy.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 2 09:31:01 PST 2018


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.

One question below.



================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:139
+                         const RegisterBankInfo &RBI,
+                         bool GetAllRegSet = false) {
   if (RB.getID() == AArch64::GPRRegBankID) {
----------------
Would it result in incorrect code if we were to always take the "all" variant?


Repository:
  rL LLVM

https://reviews.llvm.org/D42832





More information about the llvm-commits mailing list