[PATCH] D42233: [WebAssembly] Better support for WASM Object format

[Patrick Cheng via Phabricator via llvm-commits]

patcheng marked 5 inline comments as done.
patcheng added a comment.

Hopefully, the code should be good now.

Unfortunately, I need help adding the newly generated trivial.obj.wasm here F5801195: trivial.obj.wasm <https://reviews.llvm.org/F5801195> to the diff.

Thanks



================
Comment at: test/tools/llvm-objdump/wasm.txt:13
 # CHECK-NEXT:  7 CODE          00000019 0000000000000000 TEXT 
-# CHECK-NEXT:  8 DATA          0000001a 0000000000000000 DATA 
+# CHECK-NEXT:  8               00000014 0000000000000000 DATA 
 # CHECK-NEXT:  9 name          0000002b 0000000000000000 
----------------
sbc100 wrote:
> patcheng wrote:
> > Now Section.Name comes from DataSegment's Name, which is comes from linking. 
> > 
> > In `trivial.obj.wasm`, there is no names for the DataSegment, so it is currently returning nothing.
> > 
> > Should it default to "DATA"?
> > 
> > 
> Maybe we should regenerate trivial.obj.wasm?  See test/tools/llvm-readobj/Inputs/trivial.ll  for how to do this
Thanks for the tip.

I was able to regenerate trivial.obj.wasm file, and updated the test result, but I was not able to include the new .wasm as part of the patch without getting an error from Phabricator.


https://reviews.llvm.org/D42233