[PATCH] D42689: [SCEV] Fix threshold limit check

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:2437
       if (Ops.size() > AddOpsInlineThreshold ||
-          Add->getNumOperands() > AddOpsInlineThreshold)
+          (Ops.size() + Add->getNumOperands()) > AddOpsInlineThreshold)
         break;
----------------
Given that get ` Add->getNumOperands()` is always non-negative, checking both this and `Ops.size() > AddOpsInlineThreshold` makes no sense.

What was the motivation of that?


https://reviews.llvm.org/D42689