[PATCH] D42802: [DWARF] Regularize dumping strings from line tables.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

@JDevlieghere are the quoted file/directory names compatible (enough) with Darwin's dwarfdump?  I know you were working to make them compatible (although maybe it was mostly command-line compatible).



================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-header.s:327-328
 # CHECK: max_ops_per_inst: 1
-# CHECK: include_directories[  0] = 'Directory5a'
-# CHECK: include_directories[  1] = 'Directory5b'
+# CHECK: include_directories[  0] = .debug_str[0x00000045] = "Directory5a"
+# CHECK: include_directories[  1] = .debug_str[0x00000051] = "Directory5b"
 # CHECK-NOT: include_directories
----------------
dblaikie wrote:
> Should this print as ".debug_line_str"?
No, this is correct.  The referenced string section depends on the form, not on the section where the reference is made.
This test uses FORM_strp in the directory table and FORM_line_strp in the file table, to verify correct printing for both cases.  In practice I wouldn't expect a producer to mix-n-match like this, but for a test it seemed like a good idea.


https://reviews.llvm.org/D42802