[PATCH] D42667: SplitKit: Fix liveness recomputation in some remat cases.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 15:37:17 PST 2018


MatzeB added a comment.

Nice trick wmi, I tried it and could create a very small testcase that would hit the problematic code in question. Unfortunately those small inputs would not fail in -verify-machineinstrs mode without this patch (I suspect the liveranges didn't happen to actually be invalid even though we ignored the fact that PHIs can have inputs).

So I instead I manually beat against the test for multiple hours now and reduced it to 245 which should be good enough to check in.


Repository:
  rL LLVM

https://reviews.llvm.org/D42667





More information about the llvm-commits mailing list