[PATCH] D42625: [WebAssembly] Simplify use of InputChunk within Symbols. NFC.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 13:40:56 PST 2018


ruiu added a comment.

LGTM



================
Comment at: wasm/SymbolTable.cpp:124
+                             Symbol::Kind Kind, const InputChunk *Chunk) {
+  const WasmSignature* Sig = nullptr;
+  if (auto* F = dyn_cast_or_null<InputFunction>(Chunk))
----------------
nit: `WasmSignature* Sig` -> `WasmSignature *Sig`


================
Comment at: wasm/Symbols.cpp:46
 bool Symbol::hasOutputIndex() const {
-  if (Function)
-    return Function->hasOutputIndex();
+  if (auto* F = dyn_cast_or_null<InputFunction>(Chunk))
+    return F->hasOutputIndex();
----------------
`auto*` -> `auto *`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42625





More information about the llvm-commits mailing list