[PATCH] D42790: [ELF] Ensure that Elf_Rela addends are always written with -r

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 13:28:30 PST 2018


Alexander Richardson via Phabricator <reviews at reviews.llvm.org> writes:

> arichardson added a comment.
>
> In https://reviews.llvm.org/D42790#995391, @ruiu wrote:
>
>> > So should/can we switch LLD to always emit Elf_Rel for all MIPS outputs then ?
>>
>> I think I agree with George. REL/RELA is defined by the ABI and making it configurable seems odd.
>
>
> I only added the flag to make the testing easier. I can try to create the various input files using yaml2obj but that will require 4 different input files instead of just one .s file.

We are about to change the mips output to Elf_Rel, so looks like you
will be able to test this patch with llvm-mc and no extra options.

Cheers,
Rafael


More information about the llvm-commits mailing list