[PATCH] D42481: [DebugInfo] Add basic support for DWARF 5 .debug_rnglists dumping

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good to me



================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:103
+    case dwarf::DW_RLE_base_address:
+      llvm_unreachable("unimplemented rnglists encoding");
+      break;
----------------
dblaikie wrote:
> Probably more appropriate to use createError here - since it's certainly reachable by user-defined inputs. But up to you if you reckon this'll be around for a really short time.
Test cases for these, then? (the same test cases can be updated once there's better dumping support to test the behavior there)


Repository:
  rL LLVM

https://reviews.llvm.org/D42481